From 1621160d34624bcc7259b33e004e887600fd8e23 Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Mon, 28 Dec 2020 17:11:43 +0200 Subject: [PATCH] use Q_TBUFFSIZE as size for buffer in QTemporaryFile::createLocalFile() Signed-off-by: Ivailo Monev --- src/core/io/qtemporaryfile.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/core/io/qtemporaryfile.cpp b/src/core/io/qtemporaryfile.cpp index 075b6a5e4..0e7b4ebf6 100644 --- a/src/core/io/qtemporaryfile.cpp +++ b/src/core/io/qtemporaryfile.cpp @@ -499,7 +499,7 @@ QTemporaryFile *QTemporaryFile::createLocalFile(QFile &file) { if (QAbstractFileEngine *engine = file.fileEngine()) { if(engine->fileFlags(QAbstractFileEngine::FlagsMask) & QAbstractFileEngine::LocalDiskFlag) - return 0; //local already + return Q_NULLPTR; //local already //cache bool wasOpen = file.isOpen(); qint64 old_off = 0; @@ -508,15 +508,15 @@ QTemporaryFile *QTemporaryFile::createLocalFile(QFile &file) else file.open(QIODevice::ReadOnly); //dump data - QTemporaryFile *ret = new QTemporaryFile; + QTemporaryFile *ret = new QTemporaryFile(); ret->open(); file.seek(0); - char buffer[1024]; + char readbuff[QT_BUFFSIZE]; while(true) { - qint64 len = file.read(buffer, 1024); + qint64 len = file.read(readbuff, sizeof(readbuff)); if(len < 1) break; - ret->write(buffer, len); + ret->write(readbuff, len); } ret->seek(0); //restore -- 2.11.0