From 175a22c8827afea79a009c07f559454b921240bf Mon Sep 17 00:00:00 2001 From: Yi-Ling Chuang Date: Wed, 20 Feb 2019 20:00:26 +0800 Subject: [PATCH] Do not trigger card loader reloading upon screen rotation. Use the cached loaded results when it is not the first launch. Fixes: 123941365 Test: robotests Change-Id: Ib6de1142b12196e997a8c19122617e9215d23655 --- .../settings/homepage/contextualcards/ContextualCardManager.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/homepage/contextualcards/ContextualCardManager.java b/src/com/android/settings/homepage/contextualcards/ContextualCardManager.java index 344c248def..3b8aacd075 100644 --- a/src/com/android/settings/homepage/contextualcards/ContextualCardManager.java +++ b/src/com/android/settings/homepage/contextualcards/ContextualCardManager.java @@ -108,7 +108,8 @@ public class ContextualCardManager implements ContextualCardLoader.CardContentLo final CardContentLoaderCallbacks cardContentLoaderCallbacks = new CardContentLoaderCallbacks(mContext); cardContentLoaderCallbacks.setListener(this); - LoaderManager.getInstance(fragment).restartLoader(CARD_CONTENT_LOADER_ID, null /* bundle */, + // Use the cached data when navigating back to the first page and upon screen rotation. + LoaderManager.getInstance(fragment).initLoader(CARD_CONTENT_LOADER_ID, null /* bundle */, cardContentLoaderCallbacks); } @@ -192,7 +193,7 @@ public class ContextualCardManager implements ContextualCardLoader.CardContentLo Log.d(TAG, "Total loading time = " + loadTime); final List cardsToKeep = getCardsToKeep(cards); - //navigate back to the homepage or after card dismissal + //navigate back to the homepage, screen rotate or after card dismissal if (!mIsFirstLaunch) { onContextualCardUpdated(cardsToKeep.stream() .collect(groupingBy(ContextualCard::getCardType))); -- 2.11.0