From 17fbbb0b3d0b09f07d288991248c81f441bf6941 Mon Sep 17 00:00:00 2001 From: Jason Wang Date: Thu, 22 Mar 2012 18:01:50 +0800 Subject: [PATCH] e1000: conditionally raise irq at the end of MDI cycle According to the spec: "When set to 1b by software, it causes an Interrupt to be asserted to indicate the end of an MDI cycle." We need check the Interrupt Enable bit and raise irq only when it is set. Signed-off-by: Jason Wang Signed-off-by: Michael S. Tsirkin --- hw/e1000.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/e1000.c b/hw/e1000.c index dd067680c9..4e787bc2cf 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -274,7 +274,10 @@ set_mdic(E1000State *s, int index, uint32_t val) s->phy_reg[addr] = data; } s->mac_reg[MDIC] = val | E1000_MDIC_READY; - set_ics(s, 0, E1000_ICR_MDAC); + + if (val & E1000_MDIC_INT_EN) { + set_ics(s, 0, E1000_ICR_MDAC); + } } static uint32_t -- 2.11.0