From 191f4bfe8d6cf0c7d5cd7f84cd7076e32e3745dd Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Thu, 8 Aug 2019 13:26:10 -0700 Subject: [PATCH] target/arm: Use tcg_gen_extract_i32 for shifter_out_im Extract is a compact combination of shift + and. Signed-off-by: Richard Henderson Message-id: 20190808202616.13782-2-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 34e65cd80c..14d6b6d4d2 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -605,14 +605,7 @@ static void gen_sar(TCGv_i32 dest, TCGv_i32 t0, TCGv_i32 t1) static void shifter_out_im(TCGv_i32 var, int shift) { - if (shift == 0) { - tcg_gen_andi_i32(cpu_CF, var, 1); - } else { - tcg_gen_shri_i32(cpu_CF, var, shift); - if (shift != 31) { - tcg_gen_andi_i32(cpu_CF, cpu_CF, 1); - } - } + tcg_gen_extract_i32(cpu_CF, var, shift, 1); } /* Shift by immediate. Includes special handling for shift == 0. */ -- 2.11.0