From 1a6fd4d9f94d415b5112da2d42b31625899b738c Mon Sep 17 00:00:00 2001 From: Philip Reames Date: Fri, 10 Apr 2015 22:16:58 +0000 Subject: [PATCH] [RewriteStatepointsForGC] Missed review comment from 234651 & build fix After submitting 234651, I noticed I hadn't responded to a review comment by mjacob. This patch addresses that comment and fixes a Release only build problem due to an unused variable. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@234653 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/RewriteStatepointsForGC.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp b/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp index a817c8db91b..d0f2381e87b 100644 --- a/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp +++ b/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp @@ -382,6 +382,7 @@ static Value *findBaseDefiningValue(Value *I) { if (auto *EEI = dyn_cast(I)) { Value *VectorOperand = EEI->getVectorOperand(); Value *VectorBase = findBaseOfVector(VectorOperand); + (void)VectorBase; assert(VectorBase && "extract element not known to be a trivial base"); return EEI; } @@ -2060,14 +2061,14 @@ bool RewriteStatepointsForGC::runOnFunction(Function &F) { // consider those in reachable code since we need to ask dominance queries // when rewriting. We'll delete the unreachable ones in a moment. SmallVector ParsePointNeeded; - SmallVector UnreachableStatepoints; + bool HasUnreachableStatepoint = false; for (Instruction &I : inst_range(F)) { // TODO: only the ones with the flag set! if (isStatepoint(I)) { if (DT.isReachableFromEntry(I.getParent())) ParsePointNeeded.push_back(CallSite(&I)); else - UnreachableStatepoints.push_back(CallSite(&I)); + HasUnreachableStatepoint = true; } } @@ -2077,7 +2078,7 @@ bool RewriteStatepointsForGC::runOnFunction(Function &F) { // statepoints surviving this pass. This makes testing easier and the // resulting IR less confusing to human readers. Rather than be fancy, we // just reuse a utility function which removes the unreachable blocks. - if (!UnreachableStatepoints.empty()) + if (HasUnreachableStatepoint) MadeChange |= removeUnreachableBlocks(F); // Return early if no work to do. -- 2.11.0