From 1b2d59500a8c066dec413f906c480ee46f004df5 Mon Sep 17 00:00:00 2001 From: Nick Kralevich Date: Tue, 18 Jun 2013 17:56:28 -0700 Subject: [PATCH] NativeCrashListener: fix file descriptor leak. Sending thousands of crashes can result in the system eventually running out of file descriptors. Close file descriptors after we're done with them. Change-Id: I09ae9ce36426ded3fd591dda9a3550a19c2f01d3 --- services/java/com/android/server/am/NativeCrashListener.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/services/java/com/android/server/am/NativeCrashListener.java b/services/java/com/android/server/am/NativeCrashListener.java index 307ab03c0909..2c7f1f13098b 100644 --- a/services/java/com/android/server/am/NativeCrashListener.java +++ b/services/java/com/android/server/am/NativeCrashListener.java @@ -152,6 +152,13 @@ final class NativeCrashListener extends Thread { Slog.d(TAG, "Exception writing ack: " + e.getMessage()); } } + try { + Libcore.os.close(peerFd); + } catch (ErrnoException e) { + if (MORE_DEBUG) { + Slog.d(TAG, "Exception closing socket: " + e.getMessage()); + } + } } } } -- 2.11.0