From 25f58c7312769068de495af9de11d1a04071ce96 Mon Sep 17 00:00:00 2001 From: Janis Danisevskis Date: Tue, 4 Dec 2018 16:52:58 -0800 Subject: [PATCH] Fix inverted error code. During the Multithreaded keystore refactor the error code returned by getKeyCharacteristics was mistakenly inverted. Test: yes please! Bug: 120182820 Bug: 111443219 Change-Id: I5f5c07f30e0ee264ce75a5ffd2986186b9d66ce3 --- wifi/keystore/1.0/default/keystore.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wifi/keystore/1.0/default/keystore.cpp b/wifi/keystore/1.0/default/keystore.cpp index c1594e8..fef8400 100644 --- a/wifi/keystore/1.0/default/keystore.cpp +++ b/wifi/keystore/1.0/default/keystore.cpp @@ -165,7 +165,7 @@ Return Keystore::sign(const hidl_string& keyId, const hidl_vec& d auto [km_response, characteristics] = kc_future.get(); - if (KSReturn(km_response.response_code()).isOk()) { + if (!KSReturn(km_response.response_code()).isOk()) { LOG(ERROR) << AT << "getKeyCharacteristics failed: " << km_response.response_code(); _hidl_cb(KeystoreStatusCode::ERROR_UNKNOWN, {}); return Void(); -- 2.11.0