From 27b4f5d9af7d607ca9cf27e2a4959549fe001a3b Mon Sep 17 00:00:00 2001 From: Petar Jovanovic Date: Wed, 8 May 2019 14:42:13 +0000 Subject: [PATCH] [Support] Fix unit test for fs::is_local Close the temporary file after the test is done using it. If it is not closed and the file was created on NFS, it will cause the test to fail. The problem happens in the cleanup process afterwards. It first tries to delete the file but it is not really deleted. Afterwards, the program fails to delete the directory containing the file, causing the whole test to fail. Patch by Milos Stojanovic. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@360259 91177308-0d34-0410-b5e6-96231b3b80d8 --- unittests/Support/Path.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/unittests/Support/Path.cpp b/unittests/Support/Path.cpp index 750fd13db97..4eee8e923b7 100644 --- a/unittests/Support/Path.cpp +++ b/unittests/Support/Path.cpp @@ -1517,6 +1517,7 @@ TEST_F(FileSystemTest, is_local) { bool TempFileIsLocal; ASSERT_NO_ERROR(fs::is_local(FD, TempFileIsLocal)); EXPECT_EQ(TempFileIsLocal, fs::is_local(FD)); + ::close(FD); // Expect that the file and its parent directory are equally local or equally // remote. -- 2.11.0