From 28b3057757862d7ed193341c2640be54deaf3ed0 Mon Sep 17 00:00:00 2001
From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Date: Wed, 12 Oct 2011 12:11:18 -0300
Subject: [PATCH] AVRCP: Return error for invalid metadata IDs

---
 audio/avrcp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/audio/avrcp.c b/audio/avrcp.c
index a7987fb73..0ca91a554 100644
--- a/audio/avrcp.c
+++ b/audio/avrcp.c
@@ -427,6 +427,10 @@ static int player_get_media_attribute(struct avrcp_player *player,
 
 	DBG("Get media attribute: %u", id);
 
+	if (id == AVRCP_MEDIA_ATTRIBUTE_ILLEGAL ||
+			id > AVRCP_MEDIA_ATTRIBUTE_LAST)
+		return -ENOENT;
+
 	value = player->cb->get_metadata(id, player->user_data);
 	if (value == NULL) {
 		len = 0;
@@ -452,8 +456,6 @@ static int player_get_media_attribute(struct avrcp_player *player,
 			return -ENOBUFS;
 		memcpy(elem->val, valstr, len);
 		break;
-	default:
-		return -ENOENT;
 	}
 
 done:
-- 
2.11.0