From 2ba5f1f4e328dc2da47363a9feda75d5fdb9a4af Mon Sep 17 00:00:00 2001 From: Selim Cinek Date: Mon, 28 Apr 2014 20:23:30 +0200 Subject: [PATCH] Fixed race condition regarding first child max height The scroller could crash due to a race condition when updating the maxheight of the first view. Bug: 14295010 Change-Id: I911c724a26c8624e2326118e3b392ee675001bc6 --- .../android/systemui/statusbar/stack/StackScrollAlgorithm.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/stack/StackScrollAlgorithm.java b/packages/SystemUI/src/com/android/systemui/statusbar/stack/StackScrollAlgorithm.java index d9e7f6697faa..8757d57999ba 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/stack/StackScrollAlgorithm.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/stack/StackScrollAlgorithm.java @@ -542,9 +542,13 @@ public class StackScrollAlgorithm { public void onLayoutChange(View v, int left, int top, int right, int bottom, int oldLeft, int oldTop, int oldRight, int oldBottom) { - mFirstChildMaxHeight = getMaxAllowedChildHeight( - mFirstChildWhileExpanding); - mFirstChildWhileExpanding.removeOnLayoutChangeListener(this); + if (mFirstChildWhileExpanding != null) { + mFirstChildMaxHeight = getMaxAllowedChildHeight( + mFirstChildWhileExpanding); + } else { + mFirstChildMaxHeight = 0; + } + v.removeOnLayoutChangeListener(this); } }); } else { -- 2.11.0