From 2c5955b5c41c4969d1ed0ff4ccbd30b357b3d805 Mon Sep 17 00:00:00 2001 From: James Dong Date: Wed, 17 Jun 2009 16:24:08 -0700 Subject: [PATCH] Log null author command in authordriver.cpp (bug 1922537) Note this does not resolve the root cause for the mediaserver crash reported in bug 1922537: 1. why was a null author command received from the author engine (PV is looking into this issue)? 2. why was the time stamp out of the order (QCOM and PV are looking into this issue)? 3. why did we receive multiple event callbacks for a single state transition request (QCOM is looking into this issue)? --- android/author/authordriver.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/android/author/authordriver.cpp b/android/author/authordriver.cpp index 547ac44b..24d5ebbd 100644 --- a/android/author/authordriver.cpp +++ b/android/author/authordriver.cpp @@ -1100,7 +1100,11 @@ void AuthorDriver::CommandCompleted(const PVCmdResponse& aResponse) { author_command *ac = (author_command *)aResponse.GetContext(); status_t s = aResponse.GetCmdStatus(); - LOGV("Command (%d) completed with status(%d)", ac->which, s); + LOGV("Command (%d) completed with status(%d)", ac? ac->which: -1, s); + if (ac == NULL) { + LOGE("CommandCompleted: Error - null author command!"); + return; + } if (ac->which == AUTHOR_SET_OUTPUT_FORMAT) { mSelectedComposer = aResponse.GetResponseData(); -- 2.11.0