From 2c7e249b847eb26e2512b3cdcfd3ff28cf0fc427 Mon Sep 17 00:00:00 2001 From: Fyodor Kupolov Date: Wed, 23 Aug 2017 16:36:15 -0700 Subject: [PATCH] Keep close_idle_connections optimization for all devices Internal compatibility testing didn't reveal any issues related to it. Rationale to not make it specific to low-ram: 1) Consistent behavior from app perspective. close_idle_connections is a behavioural change and may affect apps relying on undocumented behavior of connection pooling. Developers can detect problems without testing on low-ram device 2) Closing idle connections is especially important in WAL mode. Disabling this feature would become an issue if more apps are switching to WAL and we would need to re-enable this optimization. Test: n/a Bug: 63398887 Change-Id: I1b431f44daa2d337aad7f12f8e1409ae3143ded0 --- core/java/android/database/sqlite/SQLiteDatabase.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/java/android/database/sqlite/SQLiteDatabase.java b/core/java/android/database/sqlite/SQLiteDatabase.java index de02ee51ac3a..59fb269c71fc 100644 --- a/core/java/android/database/sqlite/SQLiteDatabase.java +++ b/core/java/android/database/sqlite/SQLiteDatabase.java @@ -79,8 +79,6 @@ public final class SQLiteDatabase extends SQLiteClosable { private static final int EVENT_DB_CORRUPT = 75004; - // TODO b/63398887 STOPSHIP. - // Temporarily enabled for testing across a broader set of dogfood devices. private static final boolean DEBUG_CLOSE_IDLE_CONNECTIONS = SystemProperties .getBoolean("persist.debug.sqlite.close_idle_connections", true); -- 2.11.0