From 2d42ac21efe4a191f992ffd2d004b0a4e052102e Mon Sep 17 00:00:00 2001 From: Dafna Hirschfeld Date: Tue, 27 Feb 2018 23:44:27 +0200 Subject: [PATCH] staging: rtl8723bs: use kmemdup for allocation and copy Use kmemdup instead of kzalloc and memcpy to simplify the code. Issue found with coccicheck. Signed-off-by: Dafna Hirschfeld Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index d6cef9e8378d..0ce9b47d644d 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -433,13 +433,12 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool bUsedWoWLANFw) goto exit; } - pFirmware->szFwBuffer = kzalloc(fw->size, GFP_KERNEL); + pFirmware->szFwBuffer = kmemdup(fw->data, fw->size, GFP_KERNEL); if (!pFirmware->szFwBuffer) { rtStatus = _FAIL; goto exit; } - memcpy(pFirmware->szFwBuffer, fw->data, fw->size); pFirmware->ulFwLength = fw->size; release_firmware(fw); if (pFirmware->ulFwLength > FW_8723B_SIZE) { -- 2.11.0