From 2d4f7bedc0ed6f55d54db2d90c7ef4bffd827c4b Mon Sep 17 00:00:00 2001 From: kevinb Date: Tue, 12 Aug 2003 16:12:32 +0000 Subject: [PATCH] * i386-tdep.c (i386_gdbarch_init): Enable default support for SSE registers. --- gdb/ChangeLog | 5 +++++ gdb/i386-tdep.c | 23 ++++++++++++++++++----- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ce42a296d5..030ac89704 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2003-08-12 Kevin Buettner + + * i386-tdep.c (i386_gdbarch_init): Enable default support for + SSE registers. + 2003-08-10 Mark Kettenis * x86-64-tdep.h (amd64fbsd_sigtramp_start, amd64fbsd_sigtramp_end, diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 83a65eedb6..2c7afca7a3 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -1757,10 +1757,23 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) tdep = XMALLOC (struct gdbarch_tdep); gdbarch = gdbarch_alloc (&info, tdep); - /* The i386 default settings don't include the SSE registers. + /* The i386 default settings now include the SSE registers. + I386_NUM_XREGS includes mxcsr, and we don't want to count + this as one of the xmm regs -- which is why we subtract one. + + Note: kevinb/2003-07-14: Whatever Mark's concerns are about the + FPU registers in the FIXME below apply to the SSE registers as well. + The only problem that I see is that these registers will show up + in "info all-registers" even on CPUs where they don't exist. IMO, + however, if it's a choice between printing them always (even when + they don't exist) or never showing them to the user (even when they + do exist), I prefer the former over the latter. Ideally, of course, + we'd somehow autodetect that we have them (or not) and display them + when we have them and suppress them when we don't. + FIXME: kettenis/20020614: They do include the FPU registers for now, which probably is not quite right. */ - tdep->num_xmm_regs = 0; + tdep->num_xmm_regs = I386_NUM_XREGS - 1; tdep->jb_pc_offset = -1; tdep->struct_return = pcc_struct_return; @@ -1782,9 +1795,9 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) alignment. */ set_gdbarch_long_double_bit (gdbarch, 96); - /* The default ABI includes general-purpose registers and - floating-point registers. */ - set_gdbarch_num_regs (gdbarch, I386_NUM_GREGS + I386_NUM_FREGS); + /* The default ABI includes general-purpose registers, + floating-point registers, and the SSE registers. */ + set_gdbarch_num_regs (gdbarch, I386_SSE_NUM_REGS); set_gdbarch_register_name (gdbarch, i386_register_name); set_gdbarch_register_type (gdbarch, i386_register_type); -- 2.11.0