From 2e5aaf65a344ae804343bfed6326ef33f61586b0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Martin=20Storsj=C3=B6?= Date: Fri, 20 Nov 2020 11:29:27 +0200 Subject: [PATCH] [compiler-rt] [emutls] Handle unused parameters in a compiler agnostic way The MSVC specific pragmas disable this warning, but the pragmas themselves (when not guarded by any _MSC_VER ifdef) cause warnings for other targets, e.g. when targeting mingw. Instead silence the MSVC warnings about unused parameters by casting the parameters to void. Differential Revision: https://reviews.llvm.org/D91851 --- compiler-rt/lib/builtins/emutls.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/compiler-rt/lib/builtins/emutls.c b/compiler-rt/lib/builtins/emutls.c index e0aa19155f7..98cabd917d6 100644 --- a/compiler-rt/lib/builtins/emutls.c +++ b/compiler-rt/lib/builtins/emutls.c @@ -182,9 +182,10 @@ static void emutls_exit(void) { } } -#pragma warning(push) -#pragma warning(disable : 4100) static BOOL CALLBACK emutls_init(PINIT_ONCE p0, PVOID p1, PVOID *p2) { + (void)p0; + (void)p1; + (void)p2; emutls_mutex = (LPCRITICAL_SECTION)_aligned_malloc(sizeof(CRITICAL_SECTION), 16); if (!emutls_mutex) { @@ -251,8 +252,6 @@ static __inline void __atomic_store_n(void *ptr, uintptr_t val, unsigned type) { #endif // __ATOMIC_RELEASE -#pragma warning(pop) - #endif // _WIN32 static size_t emutls_num_object = 0; // number of allocated TLS objects -- 2.11.0