From 310fa65ab9acb96319d0fcb779cdd35350f5d00f Mon Sep 17 00:00:00 2001 From: Evan Cheng Date: Tue, 13 Nov 2012 02:56:38 +0000 Subject: [PATCH] Revert r167759. Ben is right this isn't likely to help much. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@167809 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/PassManagers.h | 14 ++++++-------- lib/VMCore/PassManager.cpp | 6 ++---- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/include/llvm/PassManagers.h b/include/llvm/PassManagers.h index 3acbf0e2c07..0af58533805 100644 --- a/include/llvm/PassManagers.h +++ b/include/llvm/PassManagers.h @@ -263,7 +263,7 @@ private: class PMDataManager { public: - explicit PMDataManager() : TPM(NULL), PassVectorSize(0), Depth(0) { + explicit PMDataManager() : TPM(NULL), Depth(0) { initializeAnalysisInfo(); } @@ -344,7 +344,7 @@ public: void dumpPreservedSet(const Pass *P) const; virtual unsigned getNumContainedPasses() const { - return PassVectorSize; + return (unsigned)PassVector.size(); } virtual PassManagerType getPassManagerType() const { @@ -369,16 +369,14 @@ protected: // Top level manager. PMTopLevelManager *TPM; + // Collection of pass that are managed by this manager + SmallVector PassVector; + // Collection of Analysis provided by Parent pass manager and // used by current pass manager. At at time there can not be more // then PMT_Last active pass mangers. std::map *InheritedAnalysis[PMT_Last]; - // Collection of pass that are managed by this manager - SmallVector PassVector; - - // Cache the size of PassVector - unsigned PassVectorSize; /// isPassDebuggingExecutionsOrMore - Return true if -debug-pass=Executions /// or higher is specified. @@ -446,7 +444,7 @@ public: } FunctionPass *getContainedPass(unsigned N) { - assert ( N < PassVectorSize && "Pass number out of range!"); + assert ( N < PassVector.size() && "Pass number out of range!"); FunctionPass *FP = static_cast(PassVector[N]); return FP; } diff --git a/lib/VMCore/PassManager.cpp b/lib/VMCore/PassManager.cpp index 5c209e24d81..53f11499e4b 100644 --- a/lib/VMCore/PassManager.cpp +++ b/lib/VMCore/PassManager.cpp @@ -195,7 +195,7 @@ public: } BasicBlockPass *getContainedPass(unsigned N) { - assert(N < PassVectorSize && "Pass number out of range!"); + assert(N < PassVector.size() && "Pass number out of range!"); BasicBlockPass *BP = static_cast(PassVector[N]); return BP; } @@ -346,7 +346,7 @@ public: } ModulePass *getContainedPass(unsigned N) { - assert(N < PassVectorSize && "Pass number out of range!"); + assert(N < PassVector.size() && "Pass number out of range!"); return static_cast(PassVector[N]); } @@ -963,7 +963,6 @@ void PMDataManager::add(Pass *P, bool ProcessAnalysis) { if (!ProcessAnalysis) { // Add pass PassVector.push_back(P); - ++PassVectorSize; return; } @@ -1025,7 +1024,6 @@ void PMDataManager::add(Pass *P, bool ProcessAnalysis) { // Add pass PassVector.push_back(P); - ++PassVectorSize; } -- 2.11.0