From 344684e6d02ff21ff2fce8cf1b2de3fd3cafcac7 Mon Sep 17 00:00:00 2001 From: Jason Gunthorpe Date: Sat, 12 Jan 2019 02:42:42 +0000 Subject: [PATCH] RDMA/device: Use __ib_device_get_by_name() in ib_device_rename() No reason to open code this loop. Signed-off-by: Jason Gunthorpe Reviewed-by: Steve Wise --- drivers/infiniband/core/device.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index f8180cf1a004..4a9aa6d10c5e 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -183,18 +183,15 @@ static struct ib_device *__ib_device_get_by_name(const char *name) int ib_device_rename(struct ib_device *ibdev, const char *name) { - struct ib_device *device; int ret = 0; if (!strcmp(name, dev_name(&ibdev->dev))) return ret; mutex_lock(&device_mutex); - list_for_each_entry(device, &device_list, core_list) { - if (!strcmp(name, dev_name(&device->dev))) { - ret = -EEXIST; - goto out; - } + if (__ib_device_get_by_name(name)) { + ret = -EEXIST; + goto out; } ret = device_rename(&ibdev->dev, name); -- 2.11.0