From 34fa82f7e82a2845a42d0a2725e70412d06c917b Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Thu, 5 Aug 2010 00:43:10 +0000 Subject: [PATCH] Revert r110270 for now. It appears to uncover a memdep bug. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@110293 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/BasicAliasAnalysis.cpp | 4 ++-- test/Analysis/BasicAA/getmodrefinfo-cs-cs.ll | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/Analysis/BasicAliasAnalysis.cpp b/lib/Analysis/BasicAliasAnalysis.cpp index ac06e9a2c9d..6bb84d4e458 100644 --- a/lib/Analysis/BasicAliasAnalysis.cpp +++ b/lib/Analysis/BasicAliasAnalysis.cpp @@ -425,8 +425,8 @@ BasicAliasAnalysis::getModRefInfo(ImmutableCallSite CS1, ModRefBehavior CS2B = AliasAnalysis::getModRefBehavior(CS2); if (CS2B == DoesNotAccessMemory) return NoModRef; - // If CS1 only reads from memory, just return ref. - if (CS1B == OnlyReadsMemory) + // If they both only read from memory, just return ref. + if (CS1B == OnlyReadsMemory && CS2B == OnlyReadsMemory) return Ref; // Otherwise, fall back to NoAA (mod+ref). diff --git a/test/Analysis/BasicAA/getmodrefinfo-cs-cs.ll b/test/Analysis/BasicAA/getmodrefinfo-cs-cs.ll index f655913f3d1..953eaa847d1 100644 --- a/test/Analysis/BasicAA/getmodrefinfo-cs-cs.ll +++ b/test/Analysis/BasicAA/getmodrefinfo-cs-cs.ll @@ -1,4 +1,5 @@ ; RUN: opt < %s -aa-eval -print-all-alias-modref-info -disable-output |& FileCheck %s +; XFAIL: * ; CHECK: Just Ref: call void @ro() <-> call void @f0() -- 2.11.0