From 3b29a1018457875a983bf10667cfe3a80c9d6dfd Mon Sep 17 00:00:00 2001 From: Michael Tokarev Date: Wed, 6 Apr 2011 17:51:59 +0400 Subject: [PATCH] qdev: Fix comment around qdev_init_nofail() In previous life qdev_init_nofail() used to call hw_error() which did register dump and other scary things. Now it calls error_report() and does a regular exit(1). Fix the comment to match reality. Signed-off-by: Michael Tokarev Signed-off-by: Stefan Hajnoczi --- hw/qdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/qdev.c b/hw/qdev.c index 1aa1ea0e26..9519f5dd57 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -358,7 +358,8 @@ int qdev_simple_unplug_cb(DeviceState *dev) return 0; } -/* Like qdev_init(), but terminate program via hw_error() instead of + +/* Like qdev_init(), but terminate program via error_report() instead of returning an error value. This is okay during machine creation. Don't use for hotplug, because there callers need to recover from failure. Exception: if you know the device's init() callback can't -- 2.11.0