From 3b3adcd8b617803e276b793112f55494a84a89df Mon Sep 17 00:00:00 2001 From: Chenjie Yu Date: Wed, 18 Apr 2018 16:25:36 -0700 Subject: [PATCH] fix cts error on x86 simulator Bug: 78242568 Fix: 78242568 Test: cts test Change-Id: I235991c7c5b7c5a0d660ebaaff1356cc69fd1854 --- cmds/statsd/src/external/StatsPullerManagerImpl.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/cmds/statsd/src/external/StatsPullerManagerImpl.cpp b/cmds/statsd/src/external/StatsPullerManagerImpl.cpp index 610faad85d94..c020f9c12b87 100644 --- a/cmds/statsd/src/external/StatsPullerManagerImpl.cpp +++ b/cmds/statsd/src/external/StatsPullerManagerImpl.cpp @@ -20,8 +20,8 @@ #include #include #include +#include #include -#include #include "../StatsService.h" #include "../logd/LogEvent.h" #include "../stats_log_util.h" @@ -46,6 +46,9 @@ namespace android { namespace os { namespace statsd { +// Values smaller than this may require to update the alarm. +const int64_t NO_ALARM_UPDATE = INT64_MAX; + const std::map StatsPullerManagerImpl::kAllPullAtomInfo = { // wifi_bytes_transfer {android::util::WIFI_BYTES_TRANSFER, @@ -170,7 +173,7 @@ const std::map StatsPullerManagerImpl::kAllPullAtomInfo = { // temperature {android::util::TEMPERATURE, {{}, {}, 1, new ResourceThermalManagerPuller()}}}; -StatsPullerManagerImpl::StatsPullerManagerImpl() : mNextPullTimeNs(LONG_MAX) { +StatsPullerManagerImpl::StatsPullerManagerImpl() : mNextPullTimeNs(NO_ALARM_UPDATE) { } bool StatsPullerManagerImpl::Pull(const int tagId, const int64_t timeNs, @@ -197,7 +200,7 @@ bool StatsPullerManagerImpl::PullerForMatcherExists(int tagId) const { } void StatsPullerManagerImpl::updateAlarmLocked() { - if (mNextPullTimeNs == LONG_MAX) { + if (mNextPullTimeNs == NO_ALARM_UPDATE) { VLOG("No need to set alarms. Skipping"); return; } @@ -278,7 +281,7 @@ void StatsPullerManagerImpl::UnRegisterReceiver(int tagId, wp void StatsPullerManagerImpl::OnAlarmFired(const int64_t currentTimeNs) { AutoMutex _l(mLock); - int64_t minNextPullTimeNs = LONG_MAX; + int64_t minNextPullTimeNs = NO_ALARM_UPDATE; vector>> needToPull = vector>>(); @@ -322,6 +325,8 @@ void StatsPullerManagerImpl::OnAlarmFired(const int64_t currentTimeNs) { } } + VLOG("mNextPullTimeNs: %lld updated to %lld", (long long)mNextPullTimeNs, + (long long)minNextPullTimeNs); mNextPullTimeNs = minNextPullTimeNs; updateAlarmLocked(); } -- 2.11.0