From 3bee0a46423f60df194f5ce8529530f271b68b86 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 24 Aug 2009 03:10:16 +0000 Subject: [PATCH] Run the "tablespace" regression test first not last. The former placement renders useless one of the few test methodologies we have for WAL replay, which is to intentionally crash the system just after completing the regression tests and see if it recovers to the expected database state. The reason is that DROP TABLESPACE forces a checkpoint, so there's essentially no WAL available for replay after the tests complete. --- src/test/regress/parallel_schedule | 10 ++++++---- src/test/regress/serial_schedule | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/test/regress/parallel_schedule b/src/test/regress/parallel_schedule index 82a73e319c..7d5762f916 100644 --- a/src/test/regress/parallel_schedule +++ b/src/test/regress/parallel_schedule @@ -1,10 +1,15 @@ # ---------- -# $PostgreSQL: pgsql/src/test/regress/parallel_schedule,v 1.56 2009/07/02 07:03:18 petere Exp $ +# $PostgreSQL: pgsql/src/test/regress/parallel_schedule,v 1.57 2009/08/24 03:10:16 tgl Exp $ # # By convention, we put no more than twenty tests in any one parallel group; # this limits the number of connections needed to run the tests. # ---------- +# run tablespace by itself, and first, because it forces a checkpoint; +# we'd prefer not to have checkpoints later in the tests because that +# interferes with crash-recovery testing. +test: tablespace + # ---------- # The first group of parallel tests # ---------- @@ -89,6 +94,3 @@ test: plancache limit plpgsql copy2 temp domain rangefuncs prepare without_oid c # run stats by itself because its delay may be insufficient under heavy load test: stats - -# run tablespace by itself -test: tablespace diff --git a/src/test/regress/serial_schedule b/src/test/regress/serial_schedule index 46731986e2..4f61a2d575 100644 --- a/src/test/regress/serial_schedule +++ b/src/test/regress/serial_schedule @@ -1,5 +1,6 @@ -# $PostgreSQL: pgsql/src/test/regress/serial_schedule,v 1.53 2009/07/02 07:03:18 petere Exp $ +# $PostgreSQL: pgsql/src/test/regress/serial_schedule,v 1.54 2009/08/24 03:10:16 tgl Exp $ # This should probably be in an order similar to parallel_schedule. +test: tablespace test: boolean test: char test: name @@ -121,4 +122,3 @@ test: largeobject test: with test: xml test: stats -test: tablespace -- 2.11.0