From 3d0854e4b8c0a6daaa80ac14c6bc7572a4e90916 Mon Sep 17 00:00:00 2001 From: Dharmesh Mokani Date: Tue, 9 Sep 2014 15:23:00 -0700 Subject: [PATCH] Remove STOPSHIPs from GSA 4.0 Added stopships so that GSA won't crash on older L release. Bug: 17443440 Change-Id: I792eb53d5021118bdb09c44ffae7a8286a0cd69b --- .../launcher3/compat/AppWidgetManagerCompatVL.java | 12 +++--------- .../launcher3/compat/PackageInstallerCompatVL.java | 12 ++---------- .../android/launcher3/compat/UserManagerCompatVL.java | 16 ++-------------- 3 files changed, 7 insertions(+), 33 deletions(-) diff --git a/src/com/android/launcher3/compat/AppWidgetManagerCompatVL.java b/src/com/android/launcher3/compat/AppWidgetManagerCompatVL.java index 7ca35b72d..c3853ab62 100644 --- a/src/com/android/launcher3/compat/AppWidgetManagerCompatVL.java +++ b/src/com/android/launcher3/compat/AppWidgetManagerCompatVL.java @@ -121,15 +121,9 @@ class AppWidgetManagerCompatVL extends AppWidgetManagerCompat { } else { badgeLocation.offset(bitmap.getWidth() - badgeSize - badgeMargin, top); } - Drawable drawable = null; - // STOPSHIP(mokani): Remove catch block once dogfood build is bigger than LRW70. - // This hack is just to prevent crash in older builds. - try { - drawable = mPm.getUserBadgedDrawableForDensity(new BitmapDrawable(res, bitmap), - info.getProfile(), badgeLocation, 0); - } catch (Throwable e) { - return bitmap; - } + + Drawable drawable = mPm.getUserBadgedDrawableForDensity( + new BitmapDrawable(res, bitmap), info.getProfile(), badgeLocation, 0); if (drawable instanceof BitmapDrawable) { return ((BitmapDrawable) drawable).getBitmap(); diff --git a/src/com/android/launcher3/compat/PackageInstallerCompatVL.java b/src/com/android/launcher3/compat/PackageInstallerCompatVL.java index 9a0831f0e..4ad10d870 100644 --- a/src/com/android/launcher3/compat/PackageInstallerCompatVL.java +++ b/src/com/android/launcher3/compat/PackageInstallerCompatVL.java @@ -47,11 +47,7 @@ public class PackageInstallerCompatVL extends PackageInstallerCompat { mResumed = false; mBound = false; - // STOPSHIP(mokani): Remove catch block once dogfood build is bigger than LRW70. - // This hack is just to prevent crash in older builds. - try { - mInstaller.registerSessionCallback(mCallback); - } catch (Throwable e) { } + mInstaller.registerSessionCallback(mCallback); // On start, send updates for all active sessions for (SessionInfo info : mInstaller.getAllSessions()) { @@ -77,11 +73,7 @@ public class PackageInstallerCompatVL extends PackageInstallerCompat { @Override public void onStop() { - // STOPSHIP(mokani): Remove catch block once dogfood build is bigger than LRW70. - // This hack is just to prevent crash in older builds. - try { - mInstaller.unregisterSessionCallback(mCallback); - } catch (Throwable e) { } + mInstaller.unregisterSessionCallback(mCallback); } @Override diff --git a/src/com/android/launcher3/compat/UserManagerCompatVL.java b/src/com/android/launcher3/compat/UserManagerCompatVL.java index ddef43148..19eeabdcf 100644 --- a/src/com/android/launcher3/compat/UserManagerCompatVL.java +++ b/src/com/android/launcher3/compat/UserManagerCompatVL.java @@ -51,13 +51,7 @@ public class UserManagerCompatVL extends UserManagerCompatV17 { @Override public Drawable getBadgedDrawableForUser(Drawable unbadged, UserHandleCompat user) { - // STOPSHIP(mokani): Remove catch block once dogfood build is bigger than LRW70. - // This hack is just to prevent crash in older builds. - try { - return mPm.getUserBadgedIcon(unbadged, user.getUser()); - } catch (Throwable e) { - return unbadged; - } + return mPm.getUserBadgedIcon(unbadged, user.getUser()); } @Override @@ -65,13 +59,7 @@ public class UserManagerCompatVL extends UserManagerCompatV17 { if (user == null) { return label; } - // STOPSHIP(mokani): Remove catch block once dogfood build is bigger than LRW70. - // This hack is just to prevent crash in older builds. - try { - return mPm.getUserBadgedLabel(label, user.getUser()); - } catch (Throwable e) { - return label; - } + return mPm.getUserBadgedLabel(label, user.getUser()); } } -- 2.11.0