From 3dd5fbc569ac67f34e887da5d101e5984ade3945 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Wed, 22 Feb 2017 20:49:10 -0800 Subject: [PATCH] Fix an unintentional switch-case fall-through This is a follow up CL to my previous CL [1], which introduced a classical fall through bug due to a missing return statement. [1]: Ic614f112f960382280acd8891b3af56d47679f08 ce82eb2d865e5ee1b69705ca7a0aedd0e92d0d4e Test: Manually made sure that calling InputConnection#performPrivateCommand() no longer causes IllegalStateException("Already recycled."). Bug: 35079353 Fixes: 35681994 Change-Id: I9aa3c0497385e053718d829aad49495771b22b59 --- core/java/com/android/internal/view/IInputConnectionWrapper.java | 1 + 1 file changed, 1 insertion(+) diff --git a/core/java/com/android/internal/view/IInputConnectionWrapper.java b/core/java/com/android/internal/view/IInputConnectionWrapper.java index 555263dd3699..28291aefd036 100644 --- a/core/java/com/android/internal/view/IInputConnectionWrapper.java +++ b/core/java/com/android/internal/view/IInputConnectionWrapper.java @@ -496,6 +496,7 @@ public abstract class IInputConnectionWrapper extends IInputContext.Stub { } finally { args.recycle(); } + return; } case DO_REQUEST_UPDATE_CURSOR_ANCHOR_INFO: { SomeArgs args = (SomeArgs)msg.obj; -- 2.11.0