From 4157466bdc41173a1ebd777739ea219162ae13e0 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Fri, 28 Jun 2013 10:55:41 +0000 Subject: [PATCH] Improve comment. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185141 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/Path.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/Support/Path.cpp b/lib/Support/Path.cpp index fa03df5a24a..5c28c55f267 100644 --- a/lib/Support/Path.cpp +++ b/lib/Support/Path.cpp @@ -638,8 +638,7 @@ bool is_relative(const Twine &path) { namespace fs { // This is a mkostemps with a different pattern. Unfortunatelly OS X (ond *BSD) -// don't have it. It might be worth experimenting with mkostemps on systems -// that have it. +// don't have it. We should try using mkostemps on systems that have it. error_code unique_file(const Twine &Model, int &ResultFD, SmallVectorImpl &ResultPath, bool MakeAbsolute, unsigned Mode) { @@ -648,7 +647,7 @@ error_code unique_file(const Twine &Model, int &ResultFD, } // This is a mktemp with a differet pattern. We use createUniqueEntity mostly -// for consistency. It might be worth it experimenting with mktemp. +// for consistency. We should try using mktemp. error_code unique_file(const Twine &Model, SmallVectorImpl &ResultPath, bool MakeAbsolute) { int Dummy; @@ -656,7 +655,7 @@ error_code unique_file(const Twine &Model, SmallVectorImpl &ResultPath, } // This is a mkdtemp with a different pattern. We use createUniqueEntity mostly -// for consistency. It might be worth it experimenting with mkdtemp. +// for consistency. We should try using mkdtemp. error_code createUniqueDirectory(const Twine &Prefix, SmallVectorImpl &ResultPath) { int Dummy; -- 2.11.0