From 42f3b502ce61408e09bf17196d3c0c1cf55fb7a3 Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Fri, 6 Feb 2015 22:34:48 +0000 Subject: [PATCH] Support: Stop stringifying DW_LANG_{lo,hi}_user git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@228451 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/Dwarf.cpp | 2 -- unittests/Support/DwarfTest.cpp | 10 ++++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/Support/Dwarf.cpp b/lib/Support/Dwarf.cpp index 80dfd102317..8367473c728 100644 --- a/lib/Support/Dwarf.cpp +++ b/lib/Support/Dwarf.cpp @@ -507,9 +507,7 @@ const char *llvm::dwarf::LanguageString(unsigned Language) { case DW_LANG_C_plus_plus_03: return "DW_LANG_C_plus_plus_03"; case DW_LANG_C_plus_plus_11: return "DW_LANG_C_plus_plus_11"; case DW_LANG_OCaml: return "DW_LANG_OCaml"; - case DW_LANG_lo_user: return "DW_LANG_lo_user"; case DW_LANG_Mips_Assembler: return "DW_LANG_Mips_Assembler"; - case DW_LANG_hi_user: return "DW_LANG_hi_user"; } return nullptr; } diff --git a/unittests/Support/DwarfTest.cpp b/unittests/Support/DwarfTest.cpp index d016aacedce..a1438205f73 100644 --- a/unittests/Support/DwarfTest.cpp +++ b/unittests/Support/DwarfTest.cpp @@ -42,4 +42,14 @@ TEST(DwarfTest, getTag) { EXPECT_EQ(DW_TAG_invalid, getTag("DW_TAG_user_base")); } +TEST(DwarfTest, LanguageStringOnInvalid) { + // This is invalid, so it shouldn't be stringified. + EXPECT_EQ(nullptr, LanguageString(0)); + + // These aren't really tags: they describe ranges within tags. They + // shouldn't be stringified either. + EXPECT_EQ(nullptr, LanguageString(DW_LANG_lo_user)); + EXPECT_EQ(nullptr, LanguageString(DW_LANG_hi_user)); +} + } // end namespace -- 2.11.0