From 43b013fe883933e7dcde7e2bb628ea1c6dfc444c Mon Sep 17 00:00:00 2001 From: Felipe Leme Date: Tue, 22 Dec 2015 14:09:25 -0800 Subject: [PATCH] Minor improvements on 'Take bug report' Action. Long press was returning true, which would not close the window. Comments were outdated. BUG: 26034608 Change-Id: Ia34906efff048299c709406039f86e7e14058259 --- services/core/java/com/android/server/policy/GlobalActions.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/services/core/java/com/android/server/policy/GlobalActions.java b/services/core/java/com/android/server/policy/GlobalActions.java index 5948d3cb665d..3eae7fcb6fe5 100644 --- a/services/core/java/com/android/server/policy/GlobalActions.java +++ b/services/core/java/com/android/server/policy/GlobalActions.java @@ -383,13 +383,11 @@ class GlobalActions implements DialogInterface.OnDismissListener, DialogInterfac // Add a little delay before executing, to give the // dialog a chance to go away before it takes a // screenshot. - // TODO: remove once screenshots are handled by Shell (instead of dumpstate) mHandler.postDelayed(new Runnable() { @Override public void run() { try { - // Take a "heavy" bugreport: it's more user friendly, but causes more - // interference. + // Take an "interactive" bugreport. ActivityManagerNative.getDefault().requestBugReport(true); } catch (RemoteException e) { } @@ -405,11 +403,11 @@ class GlobalActions implements DialogInterface.OnDismissListener, DialogInterfac return false; } try { - // Take a "light" bugreport, with less interference. + // Take a "full" bugreport. ActivityManagerNative.getDefault().requestBugReport(false); } catch (RemoteException e) { } - return true; + return false; } public boolean showDuringKeyguard() { -- 2.11.0