From 43f608f928cec782f0f7dad248f4430fe2581016 Mon Sep 17 00:00:00 2001 From: Cary Clark Date: Fri, 18 Feb 2011 11:30:12 -0500 Subject: [PATCH] don't start long press when selecting text The timers to initiate short press and long press shouldn't be started if text is selected. Since these presses won't provide any feedback (e.g., the context menu doesn't show up), with them disabled, the long press can turn into a drag. bug:3440375 Change-Id: I019796334a8f3090922747ae3c9e21d3b87b4a3c --- core/java/android/webkit/WebView.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/java/android/webkit/WebView.java b/core/java/android/webkit/WebView.java index 72e31901495c..74e6628d66ef 100644 --- a/core/java/android/webkit/WebView.java +++ b/core/java/android/webkit/WebView.java @@ -5508,8 +5508,8 @@ public class WebView extends AbsoluteLayout } } // Trigger the link - if (mTouchMode == TOUCH_INIT_MODE - || mTouchMode == TOUCH_DOUBLE_TAP_MODE) { + if (!mSelectingText && (mTouchMode == TOUCH_INIT_MODE + || mTouchMode == TOUCH_DOUBLE_TAP_MODE)) { mPrivateHandler.sendEmptyMessageDelayed( SWITCH_TO_SHORTPRESS, TAP_TIMEOUT); mPrivateHandler.sendEmptyMessageDelayed( -- 2.11.0