From 45115315820a14d0c3f836adafb879475736e750 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Sun, 15 Dec 2013 19:21:02 +0100 Subject: [PATCH] avformat/oggparsetheora: zero extradata padding area Fixes use of uninitialized memory Fixes: msan_uninit-mem_7f66fa0ac09d_9197_theora_a4_v6_k250_s0.ogg Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavformat/oggparsetheora.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/oggparsetheora.c b/libavformat/oggparsetheora.c index 6458b97bc0..59df17efba 100644 --- a/libavformat/oggparsetheora.c +++ b/libavformat/oggparsetheora.c @@ -131,6 +131,8 @@ static int theora_header(AVFormatContext *s, int idx) st->codec->extradata_size = 0; return err; } + memset(st->codec->extradata + cds, 0, FF_INPUT_BUFFER_PADDING_SIZE); + cdp = st->codec->extradata + st->codec->extradata_size; *cdp++ = os->psize >> 8; *cdp++ = os->psize & 0xff; -- 2.11.0