From 4756b106b372e525365c62b41df38052571c0a71 Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Thu, 28 Apr 2022 11:46:57 +0200 Subject: [PATCH] s390x/cpu_models: drop "msa5" from the TCG "max" model We don't include the "msa5" feature in the "qemu" model because it generates a warning. The PoP states: "The message-security-assist extension 5 requires the secure-hash-algorithm (SHA-512) capabilities of the message-security-assist extension 2 as a prereq- uisite. (March, 2015)" As SHA-512 won't be supported in the near future, let's just drop the feature from the "max" model. This avoids the warning and allows us for making the "max" model match the "qemu" model (except for compat machines). We don't lose much, as we only implement the function stubs for MSA, excluding any real subfunctions. Signed-off-by: David Hildenbrand Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck Reviewed-by: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/issues/897 Message-Id: <20220428094708.84835-3-david@redhat.com> Signed-off-by: Thomas Huth --- target/s390x/gen-features.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 22846121c4..7b4430f9de 100644 --- a/target/s390x/gen-features.c +++ b/target/s390x/gen-features.c @@ -743,8 +743,6 @@ static uint16_t qemu_LATEST[] = { }; /* add all new definitions before this point */ static uint16_t qemu_MAX[] = { - /* generates a dependency warning, leave it out for now */ - S390_FEAT_MSA_EXT_5, }; /****** END FEATURE DEFS ******/ -- 2.11.0