From 4a70f652ad69dee370e81afee93ee6a2d8c9becc Mon Sep 17 00:00:00 2001 From: Tom O'Neill Date: Wed, 14 Aug 2013 13:35:28 -0700 Subject: [PATCH] Move UPDATE_INTENT to SettingsInjectorService Change-Id: I657c799b791e49e4af097f3cc4afdaa8f48325ac --- src/com/android/settings/location/SettingsInjector.java | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/com/android/settings/location/SettingsInjector.java b/src/com/android/settings/location/SettingsInjector.java index 258f3fd0b7..ea760f504d 100644 --- a/src/com/android/settings/location/SettingsInjector.java +++ b/src/com/android/settings/location/SettingsInjector.java @@ -56,6 +56,9 @@ import java.util.List; * Code-sharing would require extracting {@link * android.content.pm.RegisteredServicesCache#parseServiceAttributes(android.content.res.Resources, * String, android.util.AttributeSet)} into an interface, which didn't seem worth it. + * + * TODO: register a broadcast receiver that calls updateUI() when it receives + * {@link SettingInjectorService#UPDATE_INTENT}. */ class SettingsInjector { @@ -78,15 +81,6 @@ class SettingsInjector { public static final String ATTRIBUTES_NAME = "injected-location-setting"; /** - * Intent action a client should broadcast when the value of one of its injected settings has - * changed, so that the setting can be updated in the UI. - * - * TODO: register a broadcast receiver that calls updateUI() when it receives this intent - */ - public static final String UPDATE_INTENT = - "com.android.settings.InjectedLocationSettingChanged"; - - /** * Returns a list with one {@link InjectedSetting} object for each {@link android.app.Service} * that responds to {@link #RECEIVER_INTENT} and provides the expected setting metadata. * @@ -198,9 +192,6 @@ class SettingsInjector { /** * Add settings that other apps have injected. - * - * TODO: extract InjectedLocationSettingGetter that returns an iterable over - * InjectedSetting objects, so that this class can focus on UI */ public static void addInjectedSettings(PreferenceGroup group, Context context, PreferenceManager preferenceManager) { -- 2.11.0