From 4cc0def5c3f6ddea4ae2a52f443369a602e36cf2 Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Fri, 19 May 2023 08:37:55 +0300 Subject: [PATCH] kdeplasma-addons: log epod POTD provider URL currently broken, when the URL (https://epod.usra.edu/.a/6a0105371bb32c970b02b751a11620200c-pi) is opened in chromium the picture is a small white square. go figure Signed-off-by: Ivailo Monev --- kdeplasma-addons/dataengines/potd/epodprovider.cpp | 4 ++-- kdeplasma-addons/dataengines/potd/flickrprovider.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kdeplasma-addons/dataengines/potd/epodprovider.cpp b/kdeplasma-addons/dataengines/potd/epodprovider.cpp index a7b9abad..8fcd2d7b 100644 --- a/kdeplasma-addons/dataengines/potd/epodprovider.cpp +++ b/kdeplasma-addons/dataengines/potd/epodprovider.cpp @@ -60,7 +60,8 @@ void EpodProvider::Private::pageRequestFinished(KJob *_job) int pos = exp.indexIn( data ) + pattern.length(); const QString sub = data.mid( pos-4, pattern.length()+5); - KUrl url( QString(QLatin1String( "https://epod.usra.edu/.a/%1-pi" )) .arg(sub) ); + KUrl url( QString::fromLatin1("https://epod.usra.edu/.a/%1-pi" ) .arg(sub) ); + kDebug() << "url" << url.prettyUrl(); KIO::StoredTransferJob *imageJob = KIO::storedGet( url, KIO::NoReload, KIO::HideProgressInfo ); QObject::connect(imageJob, SIGNAL(finished(KJob*)), mParent, SLOT(imageRequestFinished(KJob*)) ); } @@ -73,7 +74,6 @@ void EpodProvider::Private::imageRequestFinished( KJob *_job) return; } - // FIXME: this really should be done in a thread as this can block mImage = QImage::fromData( job->data() ); emit mParent->finished( mParent ); } diff --git a/kdeplasma-addons/dataengines/potd/flickrprovider.cpp b/kdeplasma-addons/dataengines/potd/flickrprovider.cpp index 2cd1feb5..c7dbac98 100644 --- a/kdeplasma-addons/dataengines/potd/flickrprovider.cpp +++ b/kdeplasma-addons/dataengines/potd/flickrprovider.cpp @@ -101,7 +101,7 @@ void FlickrProvider::Private::pageRequestFinished( KJob *_job ) } if (xml.error() && xml.error() != QXmlStreamReader::PrematureEndOfDocumentError) { - qWarning() << "XML ERROR:" << xml.lineNumber() << ": " << xml.errorString(); + kWarning() << "XML error" << xml.lineNumber() << ": " << xml.errorString(); } if (m_photoList.begin() != m_photoList.end()) { -- 2.11.0