From 4d410ede659448557398c84552eb0bf50ef09cbc Mon Sep 17 00:00:00 2001 From: Eino-Ville Talvala Date: Sat, 6 Oct 2012 13:50:31 -0700 Subject: [PATCH] Camera2: Fix off-by-one error in ZSL selection. Bug: 7258126 Change-Id: Ie6da4645c46a7bb0dbd11d7c6183e904f41f74fd --- services/camera/libcameraservice/camera2/ZslProcessor.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/services/camera/libcameraservice/camera2/ZslProcessor.cpp b/services/camera/libcameraservice/camera2/ZslProcessor.cpp index 520857441d..1937955a5e 100644 --- a/services/camera/libcameraservice/camera2/ZslProcessor.cpp +++ b/services/camera/libcameraservice/camera2/ZslProcessor.cpp @@ -254,11 +254,14 @@ status_t ZslProcessor::pushToReprocess(int32_t requestId) { if (mZslQueueTail != mZslQueueHead) { CameraMetadata request; size_t index = mZslQueueTail; - while (request.isEmpty() && index != mZslQueueHead) { - request = mZslQueue[index].frame; + while (index != mZslQueueHead) { + if (!mZslQueue[index].frame.isEmpty()) { + request = mZslQueue[index].frame; + break; + } index = (index + 1) % kZslBufferDepth; } - if (request.isEmpty()) { + if (index == mZslQueueHead) { ALOGV("%s: ZSL queue has no valid frames to send yet.", __FUNCTION__); return NOT_ENOUGH_DATA; -- 2.11.0