From 50eceb7229cfab68f9c5b330bcb13f7609f94edd Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Sat, 7 May 2016 17:28:03 +0000 Subject: [PATCH] micro-optimize QCoreApplicationPrivate::checkInstance() Signed-off-by: Ivailo Monev --- src/core/kernel/qcoreapplication.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/core/kernel/qcoreapplication.cpp b/src/core/kernel/qcoreapplication.cpp index 4054fb846..560f15fd8 100644 --- a/src/core/kernel/qcoreapplication.cpp +++ b/src/core/kernel/qcoreapplication.cpp @@ -157,10 +157,11 @@ QString QCoreApplicationPrivate::appName() const bool QCoreApplicationPrivate::checkInstance(const char *function) { - bool b = (QCoreApplication::self != 0); - if (!b) + if (QCoreApplication::self == 0) { qWarning("QApplication::%s: Please instantiate the QApplication object first", function); - return b; + return false; + } + return true; } void QCoreApplicationPrivate::processCommandLineArguments() -- 2.11.0