From 50f438b5616ac76ba7ea8c6dbabbbf9345a2a0cb Mon Sep 17 00:00:00 2001 From: cgf Date: Fri, 27 Jan 2006 06:08:05 +0000 Subject: [PATCH] * spawn.cc (spawn_guts): Fix potential handle leak when failing exec. --- winsup/cygwin/ChangeLog | 4 ++++ winsup/cygwin/spawn.cc | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index 1fd67e5139..1cb69b9efb 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,5 +1,9 @@ 2006-01-27 Christopher Faylor + * spawn.cc (spawn_guts): Fix potential handle leak when failing exec. + +2006-01-27 Christopher Faylor + * exceptions.cc (inside_kernel): Fix to return true if we can't get the name of the DLL for the given memory block since we are not in kernel code. diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc index 4e5982ce8c..8edbf55eb4 100644 --- a/winsup/cygwin/spawn.cc +++ b/winsup/cygwin/spawn.cc @@ -731,7 +731,8 @@ spawn_guts (const char * prog_arg, const char *const *argv, myself->exec_sendsig = NULL; } res = -1; - CloseHandle (moreinfo->myself_pinfo); + if (moreinfo->myself_pinfo) + CloseHandle (moreinfo->myself_pinfo); goto out; } -- 2.11.0