From 52d2253ff9617e0c1ad767274e8627c39776198a Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Fri, 17 Feb 2017 22:53:42 +0000 Subject: [PATCH] Revert "Add soong_javac_filter to all javac commands" This reverts commit a341bf0f8636ec42bd87058d9ba31a482cea3b6d. Breaks grok builds that replace javac with another tool: reading standard input: bufio.Scanner: token too long Change-Id: I825587c465b05c1fbddb7794dc1c84f5f2c883d1 --- core/config.mk | 2 -- core/definitions.mk | 4 ++-- core/host_dalvik_java_library.mk | 2 -- core/host_java_library.mk | 1 - core/java.mk | 1 - 5 files changed, 2 insertions(+), 8 deletions(-) diff --git a/core/config.mk b/core/config.mk index 9c926ddc8..f40f6973d 100644 --- a/core/config.mk +++ b/core/config.mk @@ -496,8 +496,6 @@ MAINDEXCLASSES := $(HOST_OUT_EXECUTABLES)/mainDexClasses SOONG_ZIP := $(SOONG_HOST_OUT_EXECUTABLES)/soong_zip ZIP2ZIP := $(SOONG_HOST_OUT_EXECUTABLES)/zip2zip -JAVAC_FILTER := $(SOONG_HOST_OUT_EXECUTABLES)/soong_javac_filter - # Always use prebuilts for ckati and makeparallel prebuilt_build_tools := prebuilts/build-tools ifeq ($(filter address,$(SANITIZE_HOST)),) diff --git a/core/definitions.mk b/core/definitions.mk index 72c4c00bd..dbbdd1dd8 100644 --- a/core/definitions.mk +++ b/core/definitions.mk @@ -2217,7 +2217,7 @@ $(if $(PRIVATE_HAS_RS_SOURCES), \ $(hide) tr ' ' '\n' < $(PRIVATE_CLASS_INTERMEDIATES_DIR)/java-source-list \ | $(NORMALIZE_PATH) | sort -u > $(PRIVATE_CLASS_INTERMEDIATES_DIR)/java-source-list-uniq $(hide) if [ -s $(PRIVATE_CLASS_INTERMEDIATES_DIR)/java-source-list-uniq ] ; then \ - ( $(1) -encoding UTF-8 \ + $(1) -encoding UTF-8 \ $(if $(findstring true,$(PRIVATE_WARNINGS_ENABLE)),$(xlint_unchecked),) \ $(2) \ $(addprefix -classpath ,$(strip \ @@ -2226,7 +2226,7 @@ $(hide) if [ -s $(PRIVATE_CLASS_INTERMEDIATES_DIR)/java-source-list-uniq ] ; the -extdirs "" -d $(PRIVATE_CLASS_INTERMEDIATES_DIR) \ $(PRIVATE_JAVACFLAGS) \ \@$(PRIVATE_CLASS_INTERMEDIATES_DIR)/java-source-list-uniq \ - || ( rm -rf $(PRIVATE_CLASS_INTERMEDIATES_DIR) ; exit 41 ) ) 2>&1 | $(JAVAC_FILTER); \ + || ( rm -rf $(PRIVATE_CLASS_INTERMEDIATES_DIR) ; exit 41 ) \ fi $(if $(PRIVATE_JAVA_LAYERS_FILE), $(hide) build/tools/java-layers.py \ $(PRIVATE_JAVA_LAYERS_FILE) \@$(PRIVATE_CLASS_INTERMEDIATES_DIR)/java-source-list-uniq,) diff --git a/core/host_dalvik_java_library.mk b/core/host_dalvik_java_library.mk index 503f67bdf..0e358447f 100644 --- a/core/host_dalvik_java_library.mk +++ b/core/host_dalvik_java_library.mk @@ -90,8 +90,6 @@ $(full_classes_compiled_jar): \ $(full_java_lib_deps) \ $(jar_manifest_file) \ $(proto_java_sources_file_stamp) \ - $(NORMALIZE_PATH) \ - $(JAVAC_FILTER) \ $(LOCAL_ADDITIONAL_DEPENDENCIES) $(transform-host-java-to-package) diff --git a/core/host_java_library.mk b/core/host_java_library.mk index ba2999f07..cc26d7cc9 100644 --- a/core/host_java_library.mk +++ b/core/host_java_library.mk @@ -69,7 +69,6 @@ $(full_classes_compiled_jar): \ $(jar_manifest_file) \ $(proto_java_sources_file_stamp) \ $(NORMALIZE_PATH) \ - $(JAVAC_FILTER) \ $(LOCAL_ADDITIONAL_DEPENDENCIES) $(transform-host-java-to-package) diff --git a/core/java.mk b/core/java.mk index 1ebe3b554..d5fcf61a8 100644 --- a/core/java.mk +++ b/core/java.mk @@ -440,7 +440,6 @@ $(full_classes_compiled_jar): \ $(RenderScript_file_stamp) \ $(proto_java_sources_file_stamp) \ $(NORMALIZE_PATH) \ - $(JAVAC_FILTER) \ $(LOCAL_ADDITIONAL_DEPENDENCIES) $(transform-java-to-classes.jar) -- 2.11.0