From 53a2d13945f9df97f608b669dbd27ce6a27b9de6 Mon Sep 17 00:00:00 2001 From: James Dong Date: Fri, 31 Aug 2012 12:18:27 -0700 Subject: [PATCH] Add setVideoScalingMode support to NuPlayer o related-to-bug: 7089195 Change-Id: Ic30d9312673f2d5837c779e023ac64468ecd4951 --- media/libmediaplayerservice/nuplayer/NuPlayer.cpp | 20 +++++++++++++++++- media/libmediaplayerservice/nuplayer/NuPlayer.h | 4 ++++ .../nuplayer/NuPlayerDriver.cpp | 24 +++++++++++++++++++++- 3 files changed, 46 insertions(+), 2 deletions(-) diff --git a/media/libmediaplayerservice/nuplayer/NuPlayer.cpp b/media/libmediaplayerservice/nuplayer/NuPlayer.cpp index 91aaafedd2..dc1e35149e 100644 --- a/media/libmediaplayerservice/nuplayer/NuPlayer.cpp +++ b/media/libmediaplayerservice/nuplayer/NuPlayer.cpp @@ -68,7 +68,8 @@ NuPlayer::NuPlayer() mSkipRenderingVideoUntilMediaTimeUs(-1ll), mVideoLateByUs(0ll), mNumFramesTotal(0ll), - mNumFramesDropped(0ll) { + mNumFramesDropped(0ll), + mVideoScalingMode(NATIVE_WINDOW_SCALING_MODE_SCALE_TO_WINDOW) { } NuPlayer::~NuPlayer() { @@ -217,6 +218,9 @@ void NuPlayer::onMessageReceived(const sp &msg) { CHECK(msg->findObject("native-window", &obj)); mNativeWindow = static_cast(obj.get()); + + // XXX - ignore error from setVideoScalingMode for now + setVideoScalingMode(mVideoScalingMode); break; } @@ -957,4 +961,18 @@ sp NuPlayer::Source::getFormat(bool audio) { return NULL; } +status_t NuPlayer::setVideoScalingMode(int32_t mode) { + mVideoScalingMode = mode; + if (mNativeWindow != NULL) { + status_t ret = native_window_set_scaling_mode( + mNativeWindow->getNativeWindow().get(), mVideoScalingMode); + if (ret != OK) { + ALOGE("Failed to set scaling mode (%d): %s", + -ret, strerror(-ret)); + return ret; + } + } + return OK; +} + } // namespace android diff --git a/media/libmediaplayerservice/nuplayer/NuPlayer.h b/media/libmediaplayerservice/nuplayer/NuPlayer.h index 996806ea4a..36d3a9cbd1 100644 --- a/media/libmediaplayerservice/nuplayer/NuPlayer.h +++ b/media/libmediaplayerservice/nuplayer/NuPlayer.h @@ -55,6 +55,8 @@ struct NuPlayer : public AHandler { // Will notify the driver through "notifySeekComplete" once finished. void seekToAsync(int64_t seekTimeUs); + status_t setVideoScalingMode(int32_t mode); + protected: virtual ~NuPlayer(); @@ -130,6 +132,8 @@ private: int64_t mVideoLateByUs; int64_t mNumFramesTotal, mNumFramesDropped; + int32_t mVideoScalingMode; + status_t instantiateDecoder(bool audio, sp *decoder); status_t feedDecoderInputData(bool audio, const sp &msg); diff --git a/media/libmediaplayerservice/nuplayer/NuPlayerDriver.cpp b/media/libmediaplayerservice/nuplayer/NuPlayerDriver.cpp index 441cbf31af..d03601fd1d 100644 --- a/media/libmediaplayerservice/nuplayer/NuPlayerDriver.cpp +++ b/media/libmediaplayerservice/nuplayer/NuPlayerDriver.cpp @@ -259,7 +259,29 @@ player_type NuPlayerDriver::playerType() { } status_t NuPlayerDriver::invoke(const Parcel &request, Parcel *reply) { - return INVALID_OPERATION; + if (reply == NULL) { + ALOGE("reply is a NULL pointer"); + return BAD_VALUE; + } + + int32_t methodId; + status_t ret = request.readInt32(&methodId); + if (ret != OK) { + ALOGE("Failed to retrieve the requested method to invoke"); + return ret; + } + + switch (methodId) { + case INVOKE_ID_SET_VIDEO_SCALING_MODE: + { + int mode = request.readInt32(); + return mPlayer->setVideoScalingMode(mode); + } + default: + { + return INVALID_OPERATION; + } + } } void NuPlayerDriver::setAudioSink(const sp &audioSink) { -- 2.11.0