From 5a939956b83abc7f0dfafb84e636115d2d559ecb Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Tue, 29 Nov 2011 00:25:57 +0000 Subject: [PATCH] edis: Sink EDMain.cpp into lib/MC/MCDisassembler. - This fixes some layering violations and matches how we handle the llvm-c lib, for example. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@145338 91177308-0d34-0410-b5e6-96231b3b80d8 --- {tools/edis => lib/MC/MCDisassembler}/EDMain.cpp | 10 ++++---- tools/CMakeLists.txt | 1 - tools/Makefile | 8 ------- tools/edis/CMakeLists.txt | 21 ----------------- tools/edis/Makefile | 30 ------------------------ 5 files changed, 4 insertions(+), 66 deletions(-) rename {tools/edis => lib/MC/MCDisassembler}/EDMain.cpp (95%) delete mode 100644 tools/edis/CMakeLists.txt delete mode 100644 tools/edis/Makefile diff --git a/tools/edis/EDMain.cpp b/lib/MC/MCDisassembler/EDMain.cpp similarity index 95% rename from tools/edis/EDMain.cpp rename to lib/MC/MCDisassembler/EDMain.cpp index 3bf2585a21a..3fd355b4bc3 100644 --- a/tools/edis/EDMain.cpp +++ b/lib/MC/MCDisassembler/EDMain.cpp @@ -11,12 +11,10 @@ // //===----------------------------------------------------------------------===// -// FIXME: This code isn't layered right, the headers should be moved to -// include llvm/MC/MCDisassembler or something. -#include "../../lib/MC/MCDisassembler/EDDisassembler.h" -#include "../../lib/MC/MCDisassembler/EDInst.h" -#include "../../lib/MC/MCDisassembler/EDOperand.h" -#include "../../lib/MC/MCDisassembler/EDToken.h" +#include "EDDisassembler.h" +#include "EDInst.h" +#include "EDOperand.h" +#include "EDToken.h" #include "llvm-c/EnhancedDisassembly.h" using namespace llvm; diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt index 28b36dcdfd1..edfd3b2b719 100644 --- a/tools/CMakeLists.txt +++ b/tools/CMakeLists.txt @@ -50,7 +50,6 @@ add_subdirectory(bugpoint) add_subdirectory(bugpoint-passes) add_subdirectory(llvm-bcanalyzer) add_subdirectory(llvm-stub) -add_subdirectory(edis) if( NOT WIN32 ) add_subdirectory(lto) diff --git a/tools/Makefile b/tools/Makefile index 278546bc162..8bbd7c2387f 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -56,14 +56,6 @@ ifeq ($(ENABLE_PIC),1) endif PARALLEL_DIRS += bugpoint-passes - - # The edis library is only supported if ARM and/or X86 are enabled, and if - # LLVM is being built PIC on platforms that support dylibs. - ifneq ($(DISABLE_EDIS),1) - ifneq ($(filter $(TARGETS_TO_BUILD), X86 ARM),) - PARALLEL_DIRS += edis - endif - endif endif ifdef LLVM_HAS_POLLY diff --git a/tools/edis/CMakeLists.txt b/tools/edis/CMakeLists.txt deleted file mode 100644 index 1e162f93183..00000000000 --- a/tools/edis/CMakeLists.txt +++ /dev/null @@ -1,21 +0,0 @@ -include_directories(${CMAKE_CURRENT_BINARY_DIR}) - -set(SOURCES - ../../include/llvm-c/EnhancedDisassembly.h - EDMain.cpp - ) - -set(EDIS_DEPENDS LLVMMCDisassembler LLVMMCParser) -if( LLVM_TARGETS_TO_BUILD MATCHES X86 ) - list(APPEND EDIS_DEPENDS LLVMX86AsmPrinter LLVMX86AsmParser LLVMX86Disassembler LLVMX86Desc) -endif() -if( LLVM_TARGETS_TO_BUILD MATCHES ARM ) - list(APPEND EDIS_DEPENDS LLVMARMAsmPrinter LLVMARMAsmParser LLVMARMDisassembler LLVMARMDesc) -endif() - -add_llvm_library(EnhancedDisassembly ${SOURCES}) -set_property(TARGET EnhancedDisassembly PROPERTY - OUTPUT_NAME "EnhancedDisassembly") - -add_llvm_library_dependencies(EnhancedDisassembly - ${EDIS_DEPENDS}) diff --git a/tools/edis/Makefile b/tools/edis/Makefile deleted file mode 100644 index 43d6f4ddc01..00000000000 --- a/tools/edis/Makefile +++ /dev/null @@ -1,30 +0,0 @@ -##===- tools/edis/Makefile -----------------------------------*- Makefile -*-===## -# -# The LLVM Compiler Infrastructure -# -# This file is distributed under the University of Illinois Open Source -# License. See LICENSE.TXT for details. -# -##===----------------------------------------------------------------------===## - -LEVEL := ../.. -LIBRARYNAME := EnhancedDisassembly - -# Include this here so we can get the configuration of the targets -# that have been configured for construction. We have to do this -# early so we can set up LINK_COMPONENTS before including Makefile.rules -include $(LEVEL)/Makefile.config - -LINK_COMPONENTS := mcdisassembler - -# If the X86 target is enabled, link in the asmprinter and disassembler. -ifneq ($(filter $(TARGETS_TO_BUILD), X86),) -LINK_COMPONENTS += x86asmprinter x86disassembler -endif - -# If the ARM target is enabled, link in the asmprinter and disassembler. -ifneq ($(filter $(TARGETS_TO_BUILD), ARM),) -LINK_COMPONENTS += armasmprinter armdisassembler -endif - -include $(LEVEL)/Makefile.common -- 2.11.0