From 5ac5bd8754b3dabcf4aea7b5f4a28a1d8494a1b0 Mon Sep 17 00:00:00 2001 From: Kevin McKinney Date: Sun, 18 Sep 2011 18:34:46 -0400 Subject: [PATCH] Staging: bcm: Add size minimum size restrictions for IOCTL_IDLE_REQ If IoBuffer.InputLength is zero then this will cause an Oops when we dereference the ZERO_SIZE_PTR. Or if it's smaller than sizeof(struct link_request) then we would get memory corruption when we set ->PLength in CopyBufferToControlPacket(). Signed-off-by: Kevin McKinney Signed-off-by: Greg Kroah-Hartman --- drivers/staging/bcm/Bcmchar.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 6f8a75dc1ef0..1905a83b3385 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers/staging/bcm/Bcmchar.c @@ -687,7 +687,9 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, ULONG arg) if (copy_from_user(&IoBuffer, argp, sizeof(IOCTL_BUFFER))) return -EFAULT; - /* FIXME: don't accept any length from user */ + if (IoBuffer.InputLength < sizeof(struct link_request)) + return -EINVAL; + pvBuffer = kmalloc(IoBuffer.InputLength, GFP_KERNEL); if (!pvBuffer) return -ENOMEM; -- 2.11.0