From 5de0e5463152272505f3fddf866f676b6df820b6 Mon Sep 17 00:00:00 2001 From: cgf Date: Sun, 7 Dec 2003 03:27:50 +0000 Subject: [PATCH] * exceptions.cc (_threadinfo::remove): Avoid a linked list walk. --- winsup/cygwin/ChangeLog | 4 ++++ winsup/cygwin/exceptions.cc | 16 +++++++--------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index 832b39f1ee..4da0b41670 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,5 +1,9 @@ 2003-12-06 Christopher Faylor + * exceptions.cc (_threadinfo::remove): Avoid a linked list walk. + +2003-12-06 Christopher Faylor + * cygtls.h (_threadinfo::find_tls): New function. * exceptions.cc (_threadinfo::find_tls): Rename from find_tls. Use critical section to protect access to linked list. diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc index ea2c7e6d57..feb36327c4 100644 --- a/winsup/cygwin/exceptions.cc +++ b/winsup/cygwin/exceptions.cc @@ -188,17 +188,15 @@ _threadinfo::init_thread (void *) void _threadinfo::remove () { - _threadinfo *t; EnterCriticalSection (&protect_linked_list); - for (t = _last_thread; t && t != this; t = t->prev) - continue; - if (t) + if (prev) { - t->prev->next = t->next; - if (t->next) - t->next->prev = t->prev; - if (t == _last_thread) - _last_thread = t->prev; + prev->next = next; + if (next) + next->prev = prev; + if (this == _last_thread) + _last_thread = prev; + prev = next = NULL; } LeaveCriticalSection (&protect_linked_list); } -- 2.11.0