From 61b09cbc027bdfe478ac79c59494953b6cea27dc Mon Sep 17 00:00:00 2001 From: Chia-chi Yeh Date: Mon, 8 Mar 2010 17:21:35 +0800 Subject: [PATCH] keystore: allow '\0's in keys and add guards for cplusplus. Change-Id: I0af6ed7c5d51ce4ca39cb837e475942800cf6e2d --- cmds/keystore/keystore_get.h | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/cmds/keystore/keystore_get.h b/cmds/keystore/keystore_get.h index 0e7e1aeabb0f..8330f8e8d3fe 100644 --- a/cmds/keystore/keystore_get.h +++ b/cmds/keystore/keystore_get.h @@ -19,7 +19,6 @@ #include #include -#include #include #include #include @@ -28,18 +27,21 @@ #define KEYSTORE_MESSAGE_SIZE 65535 +#ifdef __cplusplus +extern "C" { +#endif + /* This function is provided for native components to get values from keystore. * Users are required to link against libcutils. The lengths of keys and values * are limited to KEYSTORE_MESSAGE_SIZE. This function returns the length of * the requested value or -1 if something goes wrong. */ -static int keystore_get(const char *key, char *value) +static int keystore_get(const char *key, int length, char *value) { - int length = strlen(key); uint8_t bytes[2] = {length >> 8, length}; uint8_t code = 'g'; int sock; - if (length > KEYSTORE_MESSAGE_SIZE) { + if (length < 0 || length > KEYSTORE_MESSAGE_SIZE) { return -1; } sock = socket_local_client("keystore", ANDROID_SOCKET_NAMESPACE_RESERVED, @@ -66,4 +68,8 @@ static int keystore_get(const char *key, char *value) return length; } +#ifdef __cplusplus +} +#endif + #endif -- 2.11.0