From 61fb7bcecb6297d802dcb56d12bf107fa200640d Mon Sep 17 00:00:00 2001 From: Yifan Hong Date: Fri, 12 May 2017 16:33:57 -0700 Subject: [PATCH] Actually remove dead processes from lshal Test: run lshal with and without the change Change-Id: Id8c52a5be3253f5ff9c1cb851459a16e01ca5dda Fixes: 35765788 --- cmds/lshal/ListCommand.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmds/lshal/ListCommand.cpp b/cmds/lshal/ListCommand.cpp index fe2a7ca5c1..710b6e4c84 100644 --- a/cmds/lshal/ListCommand.cpp +++ b/cmds/lshal/ListCommand.cpp @@ -68,9 +68,9 @@ const std::string &ListCommand::getCmdline(pid_t pid) { void ListCommand::removeDeadProcesses(Pids *pids) { static const pid_t myPid = getpid(); - std::remove_if(pids->begin(), pids->end(), [this](auto pid) { + pids->erase(std::remove_if(pids->begin(), pids->end(), [this](auto pid) { return pid == myPid || this->getCmdline(pid).empty(); - }); + }), pids->end()); } bool ListCommand::getReferencedPids( -- 2.11.0