From 641636d19e3d8eeb8fac31e20641eaf33befd6e7 Mon Sep 17 00:00:00 2001 From: aliguori Date: Fri, 17 Apr 2009 20:44:06 +0000 Subject: [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2 (Kevin Wolf) This patch fixes a qcow2 corruption bug introduced in SVN Rev 5861. L2 tables are big endian, so entries must be converted before being passed to functions. This bug is easy to trigger. The following script will create and destroy a qcow2 image (the header is gone after three loop iterations): #!/bin/bash qemu-img create -f qcow2 test.qcow 1M for i in $(seq 1 10); do qemu-system-x86_64 -hda test.qcow -monitor stdio > /dev/null 2>&1 < Signed-off-by: Anthony Liguori git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@7165 c046a42c-6fe2-441c-8c8c-71466251a162 --- block-qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block-qcow2.c b/block-qcow2.c index da8fb42b0c..985214fa07 100644 --- a/block-qcow2.c +++ b/block-qcow2.c @@ -1007,7 +1007,7 @@ static int alloc_cluster_link_l2(BlockDriverState *bs, uint64_t cluster_offset, goto err; for (i = 0; i < j; i++) - free_any_clusters(bs, old_cluster[i], 1); + free_any_clusters(bs, be64_to_cpu(old_cluster[i]), 1); ret = 0; err: -- 2.11.0