From 6441bc7e5366610771b587a8cb6ff04c2861b7a5 Mon Sep 17 00:00:00 2001 From: Christopher Tate Date: Wed, 3 Sep 2014 16:11:31 -0700 Subject: [PATCH] Fix crash in KeySet dump This was unfortunately DOSing some important parts of the Package Manager's dumpsys output. Change-Id: I228f23e8e26820b40a8d8772cd5f5b04ee8317d9 --- .../com/android/server/pm/KeySetManagerService.java | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/services/core/java/com/android/server/pm/KeySetManagerService.java b/services/core/java/com/android/server/pm/KeySetManagerService.java index 37bedf3da53c..4a8e31835dd8 100644 --- a/services/core/java/com/android/server/pm/KeySetManagerService.java +++ b/services/core/java/com/android/server/pm/KeySetManagerService.java @@ -538,14 +538,17 @@ public class KeySetManagerService { pw.println(""); } printedLabel = false; - for (long keySetId : pkg.keySetData.getSigningKeySets()) { - if (!printedLabel) { - pw.print(" Signing KeySets: "); - printedLabel = true; - } else { - pw.print(", "); + final long[] signingKeySets = pkg.keySetData.getSigningKeySets(); + if (signingKeySets != null) { + for (long keySetId : signingKeySets) { + if (!printedLabel) { + pw.print(" Signing KeySets: "); + printedLabel = true; + } else { + pw.print(", "); + } + pw.print(Long.toString(keySetId)); } - pw.print(Long.toString(keySetId)); } if (printedLabel) { pw.println(""); -- 2.11.0