From 68711cebcbb4dd7f5c05245715eefa4f4d4be760 Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Tue, 18 Apr 2017 10:35:30 +1000 Subject: [PATCH] staging: ks7010: replace defines with enum types Header has multiple constants defined using preprocessor directive. In the cases where these are an integer progression an enumeration type can be used. Doing so adds documentation to the code and makes the usage explicit. Maintain original constant value, this value is returned by the device. Replace (integer progression) preprocessor constants with enumeration type. Signed-off-by: Tobin C. Harding Signed-off-by: Greg Kroah-Hartman --- drivers/staging/ks7010/ks7010_sdio.h | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 0b8b865a44c0..e9b0ad970371 100644 --- a/drivers/staging/ks7010/ks7010_sdio.h +++ b/drivers/staging/ks7010/ks7010_sdio.h @@ -62,14 +62,18 @@ enum reg_status_type { /* General Communication Register A */ #define GCR_A 0x000028 -#define GCR_A_INIT 0 -#define GCR_A_REMAP 1 -#define GCR_A_RUN 2 +enum gen_com_reg_a { + GCR_A_INIT, + GCR_A_REMAP, + GCR_A_RUN +}; /* General Communication Register B */ #define GCR_B 0x00002C -#define GCR_B_ACTIVE 0 -#define GCR_B_DOZE 1 +enum gen_com_reg_b { + GCR_B_ACTIVE, + GCR_B_DOZE +}; /* Wakeup Register */ /* #define WAKEUP 0x008104 */ -- 2.11.0