From 68992caa2e387c3a0562f091dd2d836f1d99dd10 Mon Sep 17 00:00:00 2001 From: Eric Christopher Date: Sat, 21 Feb 2015 08:32:38 +0000 Subject: [PATCH] Turn an if+llvm_unreachable into an assert and reword comment. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230132 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/Mips/MipsAsmPrinter.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/lib/Target/Mips/MipsAsmPrinter.cpp b/lib/Target/Mips/MipsAsmPrinter.cpp index aeee5e587e5..d3fd941bfcc 100644 --- a/lib/Target/Mips/MipsAsmPrinter.cpp +++ b/lib/Target/Mips/MipsAsmPrinter.cpp @@ -976,13 +976,10 @@ void MipsAsmPrinter::EmitFPCallStub( OutContext.GetOrCreateSymbol("__call_stub_fp_" + Twine(Symbol)); OutStreamer.EmitSymbolAttribute(MType, MCSA_ELF_TypeFunction); OutStreamer.EmitLabel(Stub); - // - // we just handle non pic for now. these function will not be - // called otherwise. when the full stub generation is moved here - // we need to deal with pic. - // - if (TM.getRelocationModel() == Reloc::PIC_) - llvm_unreachable("should not be here if we are compiling pic"); + + // Only handle non-pic for now. + assert(TM.getRelocationModel() != Reloc::PIC_ && + "should not be here if we are compiling pic"); TS.emitDirectiveSetReorder(); // // We need to add a MipsMCExpr class to MCTargetDesc to fully implement -- 2.11.0