From 6aabdc9fdd496416f60d518bc60f74b3b9db0607 Mon Sep 17 00:00:00 2001 From: Alexandre Ganea Date: Mon, 10 Sep 2018 13:51:21 +0000 Subject: [PATCH] [LLD][COFF] Cleanup error messages / add more coverage tests - Log the reason for a PDB or precompiled-OBJ load failure - Properly handle out-of-date PDB or precompiled-OBJ signature by displaying a corresponding error - Slightly change behavior on PDB failure: any subsequent load attempt from another OBJ would result in the same error message being logged - Slightly change behavior on PDB failure: retry with filename only if previous error was ENOENT ("no such file or directory") - Tests: a. for native PDB errors; b. cover all the cases above Differential Revision: https://reviews.llvm.org/D51559 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@341825 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/DebugInfo/PDB/GenericError.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/DebugInfo/PDB/GenericError.cpp b/lib/DebugInfo/PDB/GenericError.cpp index b6e668a74eb..95f6c15cd30 100644 --- a/lib/DebugInfo/PDB/GenericError.cpp +++ b/lib/DebugInfo/PDB/GenericError.cpp @@ -35,7 +35,7 @@ public: case pdb_error_code::invalid_utf8_path: return "The PDB file path is an invalid UTF8 sequence."; case pdb_error_code::signature_out_of_date: - return "The signature does not match; the file(s) might be out of date"; + return "The signature does not match; the file(s) might be out of date."; } llvm_unreachable("Unrecognized generic_error_code"); } -- 2.11.0