From 6de91b31ce9d5eafd62bb7dc8e0b2fe06d58bf24 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 22 Apr 2019 15:05:18 +0000 Subject: [PATCH] llvm-undname: Fix an assert-on-invalid, found by oss-fuzz git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@358891 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Demangle/MicrosoftDemangle.cpp | 2 +- test/Demangle/invalid-manglings.test | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/Demangle/MicrosoftDemangle.cpp b/lib/Demangle/MicrosoftDemangle.cpp index f9400b075e4..beb51695fc1 100644 --- a/lib/Demangle/MicrosoftDemangle.cpp +++ b/lib/Demangle/MicrosoftDemangle.cpp @@ -1040,7 +1040,7 @@ wchar_t Demangler::demangleWcharLiteral(StringView &MangledName) { uint8_t C1, C2; C1 = demangleCharLiteral(MangledName); - if (Error) + if (Error || MangledName.empty()) goto WCharLiteralError; C2 = demangleCharLiteral(MangledName); if (Error) diff --git a/test/Demangle/invalid-manglings.test b/test/Demangle/invalid-manglings.test index fb66c2b1cda..d64ec4f14d4 100644 --- a/test/Demangle/invalid-manglings.test +++ b/test/Demangle/invalid-manglings.test @@ -164,3 +164,8 @@ ; CHECK-EMPTY: ; CHECK-NEXT: ??_C@_0601234567@abcdefghijklmnopqrtsuvwxyzABCDEFGHIJKLMNOPQRTSUVWXYZabcdefghijklmnopqrtsuvwxyzABCDEFGHIJKLMNOPQRTSUVWXYZabcdefghijklmnopqrtsuvwxyz ; CHECK-NEXT: error: Invalid mangled name + +??_C@_12@?z +; CHECK-EMPTY: +; CHECK-NEXT: ??_C@_12@?z +; CHECK-NEXT: error: Invalid mangled name -- 2.11.0