From 72755a709619b1db204c675df8f1093d54e38128 Mon Sep 17 00:00:00 2001 From: "Michael S. Tsirkin" Date: Sun, 5 Jul 2009 15:58:52 +0300 Subject: [PATCH] qemu/msi: missing braces MSIX present bit is tested incorrectly, and only happens to work because the bit we are testing is 0x1. Add braces to fix this. Reported-by: Blue Swirl Signed-off-by: Michael S. Tsirkin Signed-off-by: Anthony Liguori --- hw/msix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/msix.c b/hw/msix.c index 47e014017c..3420ce9b24 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -286,8 +286,9 @@ void msix_save(PCIDevice *dev, QEMUFile *f) { unsigned n = dev->msix_entries_nr; - if (!dev->cap_present & QEMU_PCI_CAP_MSIX) + if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) { return; + } qemu_put_buffer(f, dev->msix_table_page, n * MSIX_ENTRY_SIZE); qemu_put_buffer(f, dev->msix_table_page + MSIX_PAGE_PENDING, (n + 7) / 8); -- 2.11.0