From 7a7e3f07978461b2fb018412ff1f4f41711eacab Mon Sep 17 00:00:00 2001 From: jturney Date: Tue, 19 Apr 2011 18:51:20 +0000 Subject: [PATCH] 2011-04-02 Jon TURNEY * thread.cc (semaphore::init): We cannot reliably infer anything from the existing contents of sem, so merely warn rather than return EBUSY if it looks like we are reinitialising a semaphore. --- winsup/cygwin/ChangeLog | 6 ++++++ winsup/cygwin/thread.cc | 9 ++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index a97051ad10..fe817b4c95 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,9 @@ +2011-04-02 Jon TURNEY + + * thread.cc (semaphore::init): We cannot reliably infer anything from + the existing contents of sem, so merely warn rather than return EBUSY + if it looks like we are reinitialising a semaphore. + 2011-04-19 Corinna Vinschen * autoload.cc (GetConsoleWindow): Drop. diff --git a/winsup/cygwin/thread.cc b/winsup/cygwin/thread.cc index 87167b7f98..2bd50658c5 100644 --- a/winsup/cygwin/thread.cc +++ b/winsup/cygwin/thread.cc @@ -3209,11 +3209,14 @@ semaphore::_terminate () int semaphore::init (sem_t *sem, int pshared, unsigned int value) { - /* opengroup calls this undefined */ + /* + We can't tell the difference between reinitialising an + existing semaphore and initialising a semaphore who's + contents happen to be a valid pointer + */ if (is_good_object (sem)) { - set_errno(EBUSY); - return -1; + paranoid_printf ("potential attempt to reinitialise a semaphore"); } if (value > SEM_VALUE_MAX) -- 2.11.0