From 7f8cd417828e04ef30d125a64529d93f1969aee5 Mon Sep 17 00:00:00 2001 From: Sanjoy Das Date: Mon, 18 Apr 2016 19:01:28 +0000 Subject: [PATCH] [BPI] Consider deoptimize calls as "unreachable" Summary: Calls to @llvm.experimental.deoptimize are expected to "never execute", so optimize them as such. Reviewers: chandlerc Subscribers: junbuml, mcrosier, llvm-commits Differential Revision: http://reviews.llvm.org/D19095 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@266654 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/BranchProbabilityInfo.cpp | 7 ++++++- .../BranchProbabilityInfo/deopt-intrinsic.ll | 20 ++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 test/Analysis/BranchProbabilityInfo/deopt-intrinsic.ll diff --git a/lib/Analysis/BranchProbabilityInfo.cpp b/lib/Analysis/BranchProbabilityInfo.cpp index 8512391d5ee..b431e621622 100644 --- a/lib/Analysis/BranchProbabilityInfo.cpp +++ b/lib/Analysis/BranchProbabilityInfo.cpp @@ -115,7 +115,12 @@ static const uint32_t IH_NONTAKEN_WEIGHT = 1; bool BranchProbabilityInfo::calcUnreachableHeuristics(const BasicBlock *BB) { const TerminatorInst *TI = BB->getTerminator(); if (TI->getNumSuccessors() == 0) { - if (isa(TI)) + if (isa(TI) || + // If this block is terminated by a call to + // @llvm.experimental.deoptimize then treat it like an unreachable since + // the @llvm.experimental.deoptimize call is expected to practically + // never execute. + BB->getTerminatingDeoptimizeCall()) PostDominatedByUnreachable.insert(BB); return false; } diff --git a/test/Analysis/BranchProbabilityInfo/deopt-intrinsic.ll b/test/Analysis/BranchProbabilityInfo/deopt-intrinsic.ll new file mode 100644 index 00000000000..8728d4ab8fe --- /dev/null +++ b/test/Analysis/BranchProbabilityInfo/deopt-intrinsic.ll @@ -0,0 +1,20 @@ +; RUN: opt -analyze -branch-prob < %s | FileCheck %s + +declare i32 @llvm.experimental.deoptimize.i32(...) + +define i32 @test1(i32 %a, i32 %b) { +; CHECK-LABEL: Printing analysis 'Branch Probability Analysis' for function 'test1': +entry: + %cond = icmp eq i32 %a, 42 + br i1 %cond, label %exit, label %deopt + +; CHECK: edge entry -> exit probability is 0x7ffff800 / 0x80000000 = 100.00% [HOT edge] +; CHECK: edge entry -> deopt probability is 0x00000800 / 0x80000000 = 0.00% + +deopt: + %rval = call i32(...) @llvm.experimental.deoptimize.i32() [ "deopt"() ] + ret i32 %rval + +exit: + ret i32 %b +} -- 2.11.0